Skip to content

Extension section gulp to heft migration #10565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Ashlesha-MSFT wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Extension section gulp to heft migration #10565

Ashlesha-MSFT wants to merge 4 commits into from
+41 −31

Conversation

@Ashlesha-MSFT
Copy link
Contributor

@Ashlesha-MSFT Ashlesha-MSFT commented Jan 6, 2026 •
edited
Loading

Category

  • Content fix

Related issues

What's in this Pull Request?

  • Migrate extension tutorials from gulp to heft build system
  • Updated building-form-customizer.md with heft commands and TypeScript improvements
  • Updated building-simple-cmdset-with-dialog-api.md with heft commands

@learn-build-service-prod
Copy link
Contributor

learn-build-service-prod bot commented Jan 6, 2026

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Contributor

learn-build-service-prod bot commented Jan 6, 2026

Learn Build status updates of commit f348263:

✅ Validation status: passed

File Status Preview URL Details
docs/spfx/extensions/get-started/building-form-customizer.md ✅Succeeded View
docs/spfx/extensions/get-started/building-simple-cmdset-with-dialog-api.md ✅Succeeded View

For more details, please refer to the build report.

@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label Jan 7, 2026
@andrewconnell andrewconnell self-assigned this Jan 7, 2026
@andrewconnell andrewconnell self-requested a review January 7, 2026 11:18
andrewconnell
andrewconnell requested changes Jan 7, 2026
View reviewed changes
Copy link
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the submission... please address the requested change before we can merge this. thanks again!

@andrewconnell andrewconnell added Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. pr:do-not-merge Pull request not ready to be merged and removed pr:in-review Actively reviewing pull request labels Jan 7, 2026
@learn-build-service-prod
Copy link
Contributor

learn-build-service-prod bot commented Jan 8, 2026

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Contributor

learn-build-service-prod bot commented Jan 8, 2026

Learn Build status updates of commit 42ba3e8:

✅ Validation status: passed

File Status Preview URL Details
docs/spfx/extensions/get-started/building-form-customizer.md ✅Succeeded View
docs/spfx/extensions/get-started/building-simple-cmdset-with-dialog-api.md ✅Succeeded View

For more details, please refer to the build report.

@learn-build-service-prod
Copy link
Contributor

learn-build-service-prod bot commented Jan 9, 2026

PoliCheck Scan Report

The following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans.

✅ No issues found

More information about PoliCheck

Information: PoliCheck | Severity Guidance | Term
For any questions: Try searching the learn.microsoft.com contributor guides or post your question in the Learn support channel.

@learn-build-service-prod
Copy link
Contributor

learn-build-service-prod bot commented Jan 9, 2026

Learn Build status updates of commit 1516493:

✅ Validation status: passed

File Status Preview URL Details
docs/spfx/extensions/get-started/building-form-customizer.md ✅Succeeded View
docs/spfx/extensions/get-started/building-simple-cmdset-with-dialog-api.md ✅Succeeded View
docs/spfx/extensions/get-started/building-simple-field-customizer.md ✅Succeeded View

For more details, please refer to the build report.

@Ashlesha-MSFT Ashlesha-MSFT mentioned this pull request Jan 9, 2026
Open
31 tasks
@andrewconnell andrewconnell added the pr:in-review Actively reviewing pull request label Jan 15, 2026
andrewconnell
andrewconnell requested changes Jan 15, 2026
View reviewed changes
Copy link
Collaborator

@andrewconnell andrewconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only use inline code formatting for code... not for command line statements. Command line statements should only be in bold

docs/spfx/extensions/get-started/building-form-customizer.md
Let's call out a few specific topics from the **serve.json** file

- You can see multiple different configurations that can be used to debug new, edit, and view forms with specific query parameter differences. You can define the used configuration in your gulp serve command, for example, as `gulp serve --config=helloWorld_EditForm`
- You can see multiple different configurations that can be used to debug new, edit, and view forms with specific query parameter differences. You can define the used configuration in your **heft start** command, for example, as `heft start --serve-config helloWorld_EditForm`
Copy link
Collaborator

@andrewconnell andrewconnell Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is still not correct... the second instance of heft start should not be inline code... command line statements should be bold. Inline code formatting is for code.

@andrewconnell andrewconnell removed the pr:in-review Actively reviewing pull request label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewconnell andrewconnell andrewconnell requested changes

Assignees

@andrewconnell andrewconnell

Labels

Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. pr:do-not-merge Pull request not ready to be merged

Projects

None yet

Milestone

No milestone

2 participants

@Ashlesha-MSFT @andrewconnell